Skip to content

fix(notif): filter out browser notif for new email#2756

Merged
seanaye merged 1 commit into
mainfrom
seanaye/fix/filter-out-new-email-notif
Apr 22, 2026
Merged

fix(notif): filter out browser notif for new email#2756
seanaye merged 1 commit into
mainfrom
seanaye/fix/filter-out-new-email-notif

Conversation

@seanaye
Copy link
Copy Markdown
Contributor

@seanaye seanaye commented Apr 22, 2026

filter out the browser notifications for new_email event type

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 22, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 92d813a7-ab25-4efd-96c5-46729ebe9071

📥 Commits

Reviewing files that changed from the base of the PR and between 1932ce8 and 67b8bd0.

📒 Files selected for processing (1)
  • js/app/packages/notifications/notification-platform.ts

📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes
    • Improved notification handling to suppress email notifications from appearing as browser platform notifications. This reduces notification interruptions by filtering out email alerts alongside other previously suppressed notification categories.

Walkthrough

Modified the notification filtering logic in maybeHandlePlatformNotification to exclude additional notification types from being displayed as platform notifications. The function now ignores both document_mention and new_email tagged notifications, preventing them from reaching the browser notification interface.

Changes

Cohort / File(s) Summary
Notification Filtering
js/app/packages/notifications/notification-platform.ts
Expanded early-return condition to ignore notifications with tag === 'new_email' in addition to existing tag === 'document_mention' filter.
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title follows conventional commits format (fix:) and is under 72 characters (50 chars), accurately describing the main change of filtering browser notifications for new_email events.
Description check ✅ Passed The description is related to the changeset, clearly stating the purpose of filtering browser notifications for the new_email event type.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

@seanaye seanaye merged commit 5cb545f into main Apr 22, 2026
24 checks passed
@seanaye seanaye deleted the seanaye/fix/filter-out-new-email-notif branch April 22, 2026 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants