Skip to content

Russell/no more gamer core#2805

Merged
Fake-User merged 7 commits into
mainfrom
Russell/no-more-gamer-core
Apr 23, 2026
Merged

Russell/no more gamer core#2805
Fake-User merged 7 commits into
mainfrom
Russell/no-more-gamer-core

Conversation

@Fake-User
Copy link
Copy Markdown
Contributor

No description provided.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 23, 2026

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Summary by CodeRabbit

  • Refactor

    • Consolidated and modernized panel component implementation across the application, streamlining the codebase for consistency in login screens, signup flows, banners, onboarding experiences, dialogs, compose interfaces, dropdown menus, tooltips, and toast notifications.
  • Style

    • Refined corner and edge styling on panels and containers throughout the user interface for improved visual presentation.

Walkthrough

This PR systematically replaces the ClippedPanel component with RoundPanel across authentication, layout, dialog, menu, and toast components, removes the legacy ClippedPanel implementation and related corner clip path utilities, and updates all corresponding imports.

Changes

Cohort / File(s) Summary
Authentication Components
js/app/packages/app/component/auth/Login.tsx, Signup.tsx
Replaced ClippedPanel with RoundPanel, removed cornerRadius prop and clipping-specific styling classes.
Layout & Page Components
js/app/packages/app/component/banner/Banner.tsx, dock/Dock.tsx, interactive-onboarding/InteractiveOnboarding.tsx, interactive-onboarding/lessons/command-k.tsx, split-layout/components/SplitContainer.tsx
Swapped container from ClippedPanel to RoundPanel, removing edge/corner props and clipping-related styling.
Compose Component
js/app/packages/block-email/component/compose/Compose.tsx
Updated non-mobile wrapper from ClippedPanel to RoundPanel via WrapUnlessMobile wrapper prop.
Dialog & Modal Wrappers
js/app/packages/core/component/DialogWrapper.tsx, TopBar/ShareButton.tsx
Replaced ClippedPanel container with RoundPanel across dialog and share modal cards, removed cornerRadius configuration.
Menu Components
js/app/packages/core/component/LexicalMarkdown/component/menu/ActionsMenu.tsx, EmojiMenu.tsx, MentionsMenu/MentionsMenu.tsx
Switched panel wrapper from ClippedPanel to RoundPanel, updated PANEL_DECORATION_HEIGHT references in comments to reflect new panel styling.
Preview & Tooltip
js/app/packages/core/component/DocumentPreview.tsx, UserTooltip.tsx
Changed container component from ClippedPanel to RoundPanel with minimal prop adjustments.
Toast Component
js/app/packages/core/component/Toast/Toast.tsx
Updated toast container from ClippedPanel to RoundPanel, removed edgeColor/cornerRadius props and overflow-clip class, added highlightColor support.
Core Panel Implementation
js/app/packages/core/component/RoundPanel.tsx, ClippedPanel.tsx
Added new RoundPanel component with conditional gradient background support; deleted ClippedPanel implementation (113 lines removed).
Utility Functions
js/app/packages/core/util/clipPath.ts
Removed cornerClip() utility functions that computed polygon-based clip-path values (53 lines deleted).

Possibly related PRs

🚥 Pre-merge checks | ✅ 2 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title does not follow the conventional commits format required (feat:, fix:, chore:, etc.) and uses informal language instead of a structured commit message. Reformat the title to follow conventional commits format with a type prefix (e.g., 'refactor: replace ClippedPanel with RoundPanel'). Ensure the title is under 72 characters and clearly describes the changes.
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to assess whether any description exists that relates to the changeset. Add a pull request description explaining the purpose of replacing ClippedPanel with RoundPanel, the motivation behind the change, and any migration notes for reviewers.
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Fake-User Fake-User requested a review from sedson April 23, 2026 18:05
@github-actions
Copy link
Copy Markdown

@Fake-User Fake-User merged commit 4ecf1ef into main Apr 23, 2026
23 of 24 checks passed
@Fake-User Fake-User deleted the Russell/no-more-gamer-core branch April 23, 2026 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant