Skip to content

feat(channels): seperate pagination for static vs dss attachment#2830

Merged
synoet merged 4 commits into
mainfrom
macro-czmE36ycmcqApMviztSYu-featchannels-separate-pagination-for-static-vs-dss-attachment
Apr 24, 2026
Merged

feat(channels): seperate pagination for static vs dss attachment#2830
synoet merged 4 commits into
mainfrom
macro-czmE36ycmcqApMviztSYu-featchannels-separate-pagination-for-static-vs-dss-attachment

Conversation

@synoet
Copy link
Copy Markdown
Contributor

@synoet synoet commented Apr 24, 2026

Adds filtering on the channel-attachments endpoint to distinguish between static and non-static attachments. to support seperate pagination in each list on the frontend.

@macro-application
Copy link
Copy Markdown

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 24, 2026

Warning

Rate limit exceeded

@synoet has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 41 minutes and 45 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 41 minutes and 45 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 85a7a3ef-b4fe-4e4d-a954-b663781287fc

📥 Commits

Reviewing files that changed from the base of the PR and between f2c0166 and 796ea8e.

⛔ Files ignored due to path filters (3)
  • js/app/packages/service-clients/service-storage/generated/schemas/getChannelAttachmentsParams.ts is excluded by !**/generated/**
  • js/app/packages/service-clients/service-storage/generated/zod.ts is excluded by !**/generated/**
  • rust/cloud-storage/channels/.sqlx/query-58a665360907b8fc412e9f8dcb73696b517ecdd60243bf27c9564c7b969f1143.json is excluded by !**/.sqlx/**
📒 Files selected for processing (15)
  • js/app/packages/channel/Attachments/ChannelAttachmentEntitySection.tsx
  • js/app/packages/channel/Attachments/ChannelAttachmentMediaSection.tsx
  • js/app/packages/queries/channel/channel-attachments.ts
  • js/app/packages/queries/channel/keys.ts
  • js/app/packages/queries/channel/tests/channel-attachments.test.ts
  • js/app/packages/service-clients/service-comms/client.ts
  • js/app/packages/service-clients/service-storage/openapi.json
  • rust/cloud-storage/channels/src/domain/models.rs
  • rust/cloud-storage/channels/src/domain/ports.rs
  • rust/cloud-storage/channels/src/domain/service.rs
  • rust/cloud-storage/channels/src/domain/service/test.rs
  • rust/cloud-storage/channels/src/inbound/axum_router.rs
  • rust/cloud-storage/channels/src/inbound/axum_router/test.rs
  • rust/cloud-storage/channels/src/outbound/pg_channels_repo.rs
  • rust/cloud-storage/channels/src/outbound/pg_channels_repo/tests.rs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 24, 2026

synoet added 2 commits April 24, 2026 12:50
…mcqApMviztSYu-featchannels-separate-pagination-for-static-vs-dss-attachment
@synoet synoet marked this pull request as ready for review April 24, 2026 16:55
@synoet synoet merged commit c1c7b9a into main Apr 24, 2026
40 checks passed
@synoet synoet deleted the macro-czmE36ycmcqApMviztSYu-featchannels-separate-pagination-for-static-vs-dss-attachment branch April 24, 2026 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant