fix(soup): keep chat input mounted when preview opens#2856
Conversation
Unmounting MarkdownShell runs cleanupLexical, which tears down all plugins. On remount, buildHandle returns the cached (now dead) handle, so the editor renders but ignores keystrokes. Hide with CSS instead.
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 57 minutes and 32 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
gbirman
deleted the
macro-czo711Vn4mnMn1pEwVQ3W-unable-to-enter-text-in-soup-chat-input
branch
1 participant
Summary
SoupChatInputInnerwrapped the input in<Show when={!soup.previewEntity()}>. Unmounting<MarkdownShell>rancleanupLexical, tearing down all Lexical plugins. On remount,EditorConfigBuilder.buildHandle()returned its cached_handle— whose plugins had been destroyed — so the editor DOM rendered but keystrokes went nowhere.<Show>withclassList={{ hidden: !!soup.previewEntity() }}. The editor stays mounted across preview open/close, preserving its plugin lifecycle.