Skip to content

fix(tasks): no delete prop btn in composer#2873

Merged
sedson merged 1 commit into
mainfrom
seamus/fix-props-compose-task
Apr 24, 2026
Merged

fix(tasks): no delete prop btn in composer#2873
sedson merged 1 commit into
mainfrom
seamus/fix-props-compose-task

Conversation

@sedson
Copy link
Copy Markdown
Contributor

@sedson sedson commented Apr 24, 2026

No description provided.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 24, 2026

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Summary by CodeRabbit

Release Notes

  • Changes
    • Removed delete and pin actions from the properties panel during task composition to streamline the user interface.

Walkthrough

PropertyGrid's delete and pin UI controls are now configurable through optional props in PropertiesListProps. ComposeTask disables these controls by passing false values. PropertyGrid applies these settings only to user property rows, not metadata or builtin rows.

Changes

Cohort / File(s) Summary
PropertyGrid Delete/Pin Configuration
js/app/packages/core/component/Properties/component/panel/PropertyGrid.tsx, js/app/packages/block-md/component/ComposeTask.tsx
PropertyGrid interface updated with optional withDelete and withPin configuration properties. Delete/pin controls now only apply to user property rows based on config values. ComposeTask explicitly disables both controls for its task property editing panel.
🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided by the author, which means there is no content to evaluate for relevance to the changeset. Add a pull request description explaining the purpose and rationale for disabling delete and pin controls in the task composer panel.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title follows conventional commits format with 'fix:' prefix and is 42 characters long, well under the 72-character limit. It clearly describes the main change: disabling the delete button in the task composer.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

@sedson sedson merged commit b90b4e1 into main Apr 24, 2026
23 of 24 checks passed
@sedson sedson deleted the seamus/fix-props-compose-task branch April 24, 2026 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant