Skip to content

fix(soup): navigation scroll weird on small heights#2879

Merged
dev-rb merged 1 commit into
mainfrom
rahul/fix-soup-remove-context-offset-navigation
Apr 27, 2026
Merged

fix(soup): navigation scroll weird on small heights#2879
dev-rb merged 1 commit into
mainfrom
rahul/fix-soup-remove-context-offset-navigation

Conversation

@dev-rb
Copy link
Copy Markdown
Contributor

@dev-rb dev-rb commented Apr 27, 2026

Removes the offset scroll logic from soup navigation

@github-actions
Copy link
Copy Markdown

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 27, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 2af55a19-4836-4e04-9b26-9ea13c0c06b1

📥 Commits

Reviewing files that changed from the base of the PR and between 5486f19 and ae108b4.

📒 Files selected for processing (1)
  • js/app/packages/app/component/next-soup/soup-view/use-soup-navigation-hotkeys.ts

📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes
    • Streamlined hotkey navigation scrolling in list views for more predictable and consistent behavior when navigating through items using keyboard shortcuts.

Walkthrough

Simplified the hotkey navigation's scroll behavior by removing context-offset computation, item-size-based spacing adjustments, and conditional index adjustments. Scrolling now targets the exact destination index with align: 'nearest'.

Changes

Cohort / File(s) Summary
Navigation Hotkey Behavior
js/app/packages/app/component/next-soup/soup-view/use-soup-navigation-hotkeys.ts
Removed context-offset computation, item-size-based scrolling spacing, and negative offset handling near the top boundary. Scrolling now uses exact destination index targeting with align: 'nearest', eliminating conditional index adjustments.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dev-rb dev-rb merged commit 2ee76ec into main Apr 27, 2026
23 of 24 checks passed
@dev-rb dev-rb deleted the rahul/fix-soup-remove-context-offset-navigation branch April 27, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant