fix(search): clear sub-filter caches when resetting to tab defaults

[gbirman]

The Clear button reset queryFilters but left the channel/call/email sub-filter caches in localStorage. Adding a new from: filter calls changeIndex('channels') (since the index was deactivated by Clear), which restores the cached channel_ids from localStorage — so the previously-cleared in: filter reappears.

Fix: clear all three sub-filter caches in resetToTabDefaults.

[macro-application]

[search] Clear button does not clear channel filters

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: b99a190d-2507-4a96-b595-71b36a0751f8

📥 Commits

Reviewing files that changed from the base of the PR and between e9a9032 and 6addb56.

📒 Files selected for processing (1)

• js/app/packages/app/component/next-soup/soup-view/filters-bar/use-filter-refinements.tsx

---

📝 Walkthrough

Summary by CodeRabbit

• Bug Fixes
  • Improved filter reset behavior to properly clear cached data for channel, call, and email sub-filters.

Walkthrough

This PR modifies useFilterRefinements to import cache-reset helpers for channel, call, and email sub-filters. The resetToTabDefaults function now explicitly invalidates these cached sub-filter states by calling the imported helpers within the reset batch operation.

Changes

Cohort / File(s)	Summary
Sub-filter cache invalidation during reset js/app/packages/app/component/next-soup/soup-view/filters-bar/use-filter-refinements.tsx	Added imports for channel/call/email cache-reset helpers and integrated cache invalidation into resetToTabDefaults to clear cached sub-filter state when resetting to tab defaults.

Possibly related PRs

• feat(search): tasks-style filter menu with F hotkey and chips #2623: Adds exported cache helper functions and cache-aware index/sub-filter logic that are directly utilized by this PR's cache-reset calls in resetToTabDefaults.
• feat(search): clear search filters button  #2500: Modifies channel sub-filter caching behavior with cache invalidation, aligning with this PR's approach to clearing cached channel/call/email sub-filters during reset.
• feat(search): cache channel filters #2498: Adds soup-view per-content sub-filter caching for channels; this PR explicitly clears that same cached state during tab resets.

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title follows conventional commits format with 'fix:' prefix and clearly describes the main change of clearing sub-filter caches during tab reset.
Description check	✅ Passed	The description is directly related to the changeset, explaining the bug that was fixed and the solution implemented in the code changes.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Preview: https://macro-czmf9cjppjv7evu7lmphi-se-45wa9u.preview.macro.com/app (1a19f8e)