fix(teams): tier changes not giving proper feedback

[dev-rb]

This PR updates the tier change to display toasts using toast.promise and apply an optimistic update because the backend request takes a while to complete. Also, this fixes an issue where changing your own tier wasn't reflecting in the subscription tab of settings

[coderabbitai]

Warning

Rate limit exceeded

@dev-rb has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 40 minutes and 44 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: b1a575ff-2808-4257-b061-d7388dba4aac

📥 Commits

Reviewing files that changed from the base of the PR and between 56c04c6 and ebc3e32.

📒 Files selected for processing (2)

• js/app/packages/app/component/settings/Team.tsx
• js/app/packages/queries/team/members.ts

📝 Walkthrough

Walkthrough

Team member tier update flow enhanced with asynchronous mutation handling and optimistic cache updates. The UI component now displays loading and result toasts, while the mutation layer implements optimistic updates with rollback on failure and additional cache invalidations for user info and quota when the current user's tier changes.

Changes

Cohort / File(s)	Summary
UI Component Tier Updates js/app/packages/app/component/settings/Team.tsx	Switched from synchronous mutate to asynchronous mutateAsync for tier patch mutations, wrapped with toast.promise() to display loading, success, and failure messages to users.
Tier Mutation Query Logic js/app/packages/queries/team/members.ts	Implemented optimistic updates with cache snapshots on onMutate, rollback on onError using saved context, and extended onSuccess to invalidate user info and quota queries when the updated member is the current user.

Possibly related PRs

• feat(teams): client methods, queries, and mutations #2798: Directly extends the usePatchTeamUserTierMutation behavior by introducing the optimistic update lifecycle and additional cache invalidation logic referenced in this PR.

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The PR title follows conventional commits format with 'fix:' prefix and is 51 characters, well under the 72-character limit, accurately summarizing the main change.
Description check	✅ Passed	The description is directly related to the changeset, explaining the toast.promise implementation, optimistic updates for tier changes, and the fix for subscription tab reflection.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Preview: https://rahul-fix-teams-optimistic-upd-xwycop.preview.macro.com/app (58b79d2)

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@js/app/packages/app/component/settings/Team.tsx`:
- Around line 514-527: The call to toast.promise wrapping
patchTierMutation.mutateAsync(...) produces an unhandled floating promise;
prefix the expression with void to mark it intentionally fire-and-forget (i.e.,
change the call site that uses toast.promise to use void toast.promise(...)).
Locate the call that passes patchTierMutation.mutateAsync({ teamId:
props.teamId, request: { team_user_id: member.user_id, new_tier: newTier } })
into toast.promise and add the void prefix so lint/unchecked-rejection warnings
are suppressed while preserving existing onError handling.

In `@js/app/packages/queries/team/members.ts`:
- Around line 70-80: The cached userInfo check uses the wrong field and type;
change the getQueryData call to use the canonical UserInfoData type (import
UserInfoData from `@queries/auth`) and compare userInfo.id to request.team_user_id
(not userId), then keep the existing invalidateQueries calls for
authKeys.userInfo.queryKey and authKeys.userQuota.queryKey so they fire when the
current user’s tier changes.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 39d2f1a0-4fd3-4222-aac2-d5dc3b7b9a60

📥 Commits

Reviewing files that changed from the base of the PR and between 0e0d05a and 56c04c6.

📒 Files selected for processing (2)

• js/app/packages/app/component/settings/Team.tsx
• js/app/packages/queries/team/members.ts