feat: mark email done on send #339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FRO-293 Sending in Email/Channel should Send and Mark as Done.
Email, easy. For Channel need to think thru what exactly we mean. I think:
Eventually this should apply to document comments as well. Also: this should probably be a setting that can be turned on/off. Doesn't seem obvious to me that this is what everyone will want. |
peterchinman
force-pushed
the
peter/fro-293-sending-in-emailchannel-should-send-and-mark-as-done
branch
from
3682ad7 to
d0237d4
Compare
seanaye
force-pushed
the
peter/fro-293-sending-in-emailchannel-should-send-and-mark-as-done
branch
from
0a96a24 to
a98814a
Compare
seanaye
force-pushed
the
main
branch
2 times, most recently
from
6ca0007 to
d484247
Compare
seanaye
force-pushed
the
peter/fro-293-sending-in-emailchannel-should-send-and-mark-as-done
branch
2 times, most recently
from
c68045b to
f1e3d7d
Compare
seanaye
force-pushed
the
peter/fro-293-sending-in-emailchannel-should-send-and-mark-as-done
branch
from
f1e3d7d to
c515e02
Compare
synoet
approved these changes
Nov 30, 2025
Comment on lines
-355
to
368
| const sendEmail = async () => { | ||
| if (isPendingSend() || isPendingUpload()) return; | ||
| const sendEmail = async (): Promise<boolean> => { | ||
| if (isPendingSend() || isPendingUpload()) return false; | ||
| setIsPendingSend(true); | ||
| const to = form().recipients.to.map(convertEmailRecipientToContactInfo); | ||
| const cc = form().recipients.cc.map(convertEmailRecipientToContactInfo); | ||
| const bcc = form().recipients.bcc.map(convertEmailRecipientToContactInfo); | ||
|
|
||
| if ((to?.length ?? 0) + (cc?.length ?? 0) + (bcc?.length ?? 0) === 0) { | ||
| toast.failure('Email failed to send. No recipients provided'); | ||
| return; | ||
| setIsPendingSend(false); | ||
| return false; | ||
| } |
Contributor
There was a problem hiding this comment.
In the future would be great if we pulled this logic out of component body
Contributor
Author
There was a problem hiding this comment.
yes, agreed, I'll purify BaseInput at some point
peterchinman
deleted the
peter/fro-293-sending-in-emailchannel-should-send-and-mark-as-done
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emails are now by default marked as done on send.
Additionally, emails with tables now get a white background.