feat(notifications): handle on click for browser notifications #357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M-5269 browser notification click should go to notification
Clicking on a browser notification should take you directly to the notification in the channel or in the email |
seanaye
force-pushed
the
synoet/m-5269-browser-notification-click-should-go-to-notification
branch
from
6203112 to
fb306f1
Compare
seanaye
force-pushed
the
main
branch
2 times, most recently
from
5e5b6ba to
42fd90f
Compare
seanaye
force-pushed
the
synoet/m-5269-browser-notification-click-should-go-to-notification
branch
from
fb306f1 to
06a750d
Compare
seanaye
force-pushed
the
synoet/m-5269-browser-notification-click-should-go-to-notification
branch
from
06a750d to
b37c9be
Compare
…browser-notification-click-should-go-to-notification
sedson
approved these changes
Dec 1, 2025
| replaceOrInsertSplit({ type: 'email', id: targetId }); | ||
| break; | ||
| handle?.goToLocationFromParams({ | ||
| messageId, |
Contributor
There was a problem hiding this comment.
is this for both email and channel? I don't think those are the right param names for channels - idk about email. it's ugly but we should be importing the URL_PARAM constants from the blocks here i think?
| n.eventItemId | ||
| ) | ||
| ) | ||
| .with( |
synoet
deleted the
synoet/m-5269-browser-notification-click-should-go-to-notification
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for clicking on a browser / platform notification to open the notification. Centralizes some of the sprawling logic for doing this within the app.