Skip to content

chore(notifications): unify notification setting and persisted signal logic #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
synoet merged 3 commits into from
Dec 1, 2025
Merged

chore(notifications): unify notification setting and persisted signal logic #384

synoet merged 3 commits into from
Dec 1, 2025

Conversation

@synoet
Copy link
Contributor

@synoet synoet commented Dec 1, 2025 •
edited
Loading

  • Centralizes some of the notification permission / settings logic into the notification package.
  • removes the not needed notification options in settings.

@synoet synoet requested a review from a team as a code owner December 1, 2025 20:09
@synoet synoet merged commit 6bfdf24 into main Dec 1, 2025
19 checks passed
@synoet synoet deleted the synoet/unify-notification-settings branch December 1, 2025 20:33
@synoet synoet mentioned this pull request Dec 2, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peterchinman peterchinman peterchinman approved these changes

Assignees

@synoet synoet

Labels

web-app

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@synoet @peterchinman