Skip to content

fix: sender field for soup emails falls back to email address #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
peterchinman merged 3 commits into from
Dec 1, 2025
Merged

fix: sender field for soup emails falls back to email address #385

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4098571
fix: display email address as fallback
peterchinman Dec 1, 2025
8f2480d
only show part before at
peterchinman Dec 1, 2025
f48abc2
biome
peterchinman Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion js/app/packages/macro-entity/src/components/EntityWithEverything.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,9 @@ export function EntityWithEverything(
<div class="flex w-[20cqw] gap-2 font-semibold shrink-0">
{/* Sender Name */}
<div class="truncate">
{displayedNames() ?? props.entity.senderName}
{displayedNames() ??
props.entity.senderName ??
props.entity.senderEmail?.split('@')[0]}
</div>
{/* Sender Email Address */}
{/* <Show
Expand Down