fix(email): need to call init always to set link #392
Merged
+49
−72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterchinman
reviewed
Dec 1, 2025
dev-rb
approved these changes
Dec 1, 2025
dev-rb
pushed a commit
that referenced
this pull request
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was my mistake. I made an incorrect assumption when refactoring email linking logic. I was assuming that email links got created during sso login in both fusion auth and email service, but it turns out
emailClient.initcreates the link in email_service.This pr changes it so on connect & on signup we try to call
emailClient.initand properly check the error for a400if it already exists to not panic.Unrelated: seems like error codes aren't being properly propogated from email client rn.