Skip to content

Conversation

@gbirman
Copy link
Contributor

@gbirman gbirman commented Dec 2, 2025

Summary

this should make name search feel faster

Screenshots, GIFs, and Videos

@gbirman gbirman requested a review from a team as a code owner December 2, 2025 18:47
@linear
Copy link

linear bot commented Dec 2, 2025

@gbirman gbirman requested a review from synoet December 2, 2025 19:00
@whutchinson98
Copy link
Member

@gbirman want to add a quick video in here that shows the console to see how much we are calling search?

@gbirman
Copy link
Contributor Author

gbirman commented Dec 2, 2025

CleanShot.2025-12-02.at.14.24.15.mp4

video

@gbirman gbirman requested a review from whutchinson98 December 2, 2025 19:24
@gbirman
Copy link
Contributor Author

gbirman commented Dec 2, 2025

CleanShot.2025-12-02.at.14.25.16.mp4

unified list. the infinite soup query is unrelated, but happened as an effect of soup including emails. we will need to split out emails from the front end but that will be a follow up PR. ticketed here https://linear.app/macro-eng/issue/M-5320/do-not-infinitely-search-emails-in-soup

@gbirman gbirman merged commit 7434118 into main Dec 2, 2025
18 checks passed
@gbirman gbirman deleted the gab/m-5314-remove-debounce-on-cmd-k-search branch December 2, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants