fix(soup): soup without email link #427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "dep:model_user", | ||
| "dep:utoipa", | ||
| "email/axum", | ||
| "item_filters/schema", |
Contributor
Author
There was a problem hiding this comment.
Its a missing feature right now if you run cargo test -p soup --all-features
| State(service): State<SoupRouterState<T, U>>, | ||
| Cached(MacroUserExtractor { macro_user_id, .. }): Cached<MacroUserExtractor>, | ||
| Cached(EmailLinkExtractor(link, _)): Cached<EmailLinkExtractor<U>>, | ||
| email_link: Result<Cached<EmailLinkExtractor<U>>, EmailLinkErr>, |
Member
There was a problem hiding this comment.
should this be cached? if the user enables email won't the link extractor be none even tho there should be one?
Contributor
Author
There was a problem hiding this comment.
axum cache is unique per http request, it means if the handler tries to extract multiple times it will only query the db 1 time for that request
synoet
approved these changes
Dec 2, 2025
whutchinson98
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where soup would fail if the user does not have an email link.
There is unit tests for the changed behaviour
Screenshots, GIFs, and Videos