fix[channels]: jump to reply input on tab focus #434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dev-rb
approved these changes
Dec 3, 2025
sedson
approved these changes
Dec 3, 2025
| }, 0); | ||
| } | ||
|
|
||
| if (ref() && props.onFocus) { |
Contributor
There was a problem hiding this comment.
don't think it matters here but this is not reactive on props.onFocus. passing the onfocus handler as static on componnet init is the expected thing but i have footgunned myself on this before
…fix-channel-scrollig
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reply input portaller had some logic that if a thread reply portal mount changed, we should refocus that reply input. This allows a thread reply input to stay focused as it gets moved around the DOM as other thread messages come in.
However, when we refetched channel data on browser tab focus, this effect was running. Now the effect checks if a thread reply input was the previously focused element before focusing it.