fix(macrodb): Remove backfill operation from db migration #445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whutchinson98
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updating the db migration for the changes I just merged to not perform the backfill as a sql update operation.
While this works fine in dev and locally, the scale of prod results in a bunch of locks while the large amount of messages are updating.
We don't even need to backfill this stuff, as all the logic for fetching contact names is a coalesce on the email_contacts table anyway. The backfill was just putting what was already in email_contacts into the email_message / email_recipients table.
I ran the old migration in dev already so i'll manually revert the changes it made, update the
_sqlx_migrationstable accordingly, and rerun this new migration.The prod one I cancelled midway through so it effectively didn't run, so no changes are needed there.
Screenshots, GIFs, and Videos