fix [properties-be] - allow view access for publicly shared entities #446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When get_users_access_level_v2 returns no access, fall back to checking if the entity is publicly shared via SharePermission.isPublic. This fixes the issue where users couldn't view properties on publicly shared documents because the permission check was too strict.
whutchinson98
requested changes
Dec 4, 2025
Member
whutchinson98
left a comment
whutchinson98
left a comment
There was a problem hiding this comment.
get_users_access_level_v2 should be returning correct access level even if the item is public and not explicitly shared with you via channels.
All of our access middleware uses these calls and works as expected so not sure why you are having this bug.
…d entities" This reverts commit b3b23ef.
rust/cloud-storage/properties_service/src/api/properties/entities/get.rs
Outdated
Show resolved
Hide resolved
…ties - Use initialize_user_context + attach_user middleware on properties router - Add ensure_user_exists middleware to authenticated routes only - GET entity properties allows anonymous access for public entities
whutchinson98
approved these changes
Dec 4, 2025
danielkweon
deleted the
daniel/m-5242-fix-properties-be-view-only-entity-properties
branch
nickisnoble
pushed a commit
that referenced
this pull request
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix [properties-be] - allow view access for publicly shared entities