-
Notifications
You must be signed in to change notification settings - Fork 3
feat(auth-service): get_names_with_email endpoint #455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
evanhutnik
merged 6 commits into
main
from
evan/bac-138-update-user-preview-call-in-auth-service-to-coalesce-on
Dec 5, 2025
Merged
feat(auth-service): get_names_with_email endpoint #455
evanhutnik
merged 6 commits into
main
from
evan/bac-138-update-user-preview-call-in-auth-service-to-coalesce-on
Dec 5, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whutchinson98
requested changes
Dec 5, 2025
rust/cloud-storage/authentication_service/src/api/user/post_get_names.rs
Outdated
Show resolved
Hide resolved
rust/cloud-storage/authentication_service/src/api/user/post_get_names_with_email.rs
Show resolved
Hide resolved
rust/cloud-storage/authentication_service/src/api/user/post_get_names_with_email.rs
Outdated
Show resolved
Hide resolved
rust/cloud-storage/authentication_service/src/api/user/post_get_names_with_email.rs
Outdated
Show resolved
Hide resolved
| operation_id = "get_user_names_with_email", | ||
| responses( | ||
| (status = 200, body=UserNames), | ||
| (status = 401, body=String), |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing 400 for user ids being empty
whutchinson98
approved these changes
Dec 5, 2025
nickisnoble
pushed a commit
that referenced
this pull request
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding new endpoint to auth service,
POST /users/get_names_with_emails.Similar to the existing
POST /users/get_namesendpoint, this one queries for the names for user_ids passed to it. The difference is if the user has not joined Macro or set a name in Macro, it falls back to checking for a name from the user's email contacts.I added this as a separate endpoint, as the existing
/get_namesendpoint doesn't require authentication, but this one does (as we are using the authenticated user's email contacts). Also, there are use cases where we ONLY want the names from the Macro users. For example, theGet Channelsendpoint uses/get_namesto get the names for participants of a Macro channel. We don't want to include email contact names in this case as it would result in a mismatch between what that endpoint would return and what they would see when actually interacting with the user in Macro.Email names are a single
namecolumn, so we do a (Peter approved) best-effort approach for splitting into first and last name, where we setfirst_nameto the first word in the contact name, andlast_nameto the rest of it.Screenshots, GIFs, and Videos