fix(email-service): email upload attachment endpoint issues #483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whutchinson98
approved these changes
Dec 8, 2025
evanhutnik
deleted the
evan/comms-55-email-upload-attachment-endpoint-issues
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updating logic for uploading of email attachments to DSS.
If a previously-uploaded attachment has been soft-deleted by the user, we should not serve that ID for the attachment anymore and should re-upload the attachment to DSS as if it never existed.
When uploading an attachment on-demand for a user (not during the backfill or inbox syncing process, but when they click on the attachment in the email block), we should set the
created_at/updated_at/viewed_atfor the document tonow()so it shows up at the top of soup, instead of the timestamp of when the email was sent.Screenshots, GIFs, and Videos