feat(email-service): Add entity properties for uploaded email attachments #504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whutchinson98
approved these changes
Dec 9, 2025
evanhutnik
deleted the
evan/comms-62-add-properties-support-for-email-attachments
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add entity properties (
sender,recipients,subject,source) for email attachments when uploaded to DSS.Similar to DSS, I had to use
SystemPropertiesServiceImpldirectly in theAPIContextandPubSubContextdue to the context objects implementingFromRef. Not sure if this is the best approach, but open to suggestions.Updated the
system_propertiescrate to useMacroUserIdforEmailProperties.Tested all four of the attachment upload flows and they are all successfully publishing properties for uploaded attachments.
Screenshots, GIFs, and Videos