Conversation
…emails-in-block-email-and-in-soup-dont-live-update
dev-rb
approved these changes
Dec 9, 2025
| callback(newNotifications); | ||
| } | ||
| createEffect(() => { | ||
| let cleanup: (() => void) | undefined; |
Contributor
There was a problem hiding this comment.
nit: just inline this const cleanup = notificationSource.subscribe....
synoet
deleted the
synoet/m-5369-emails-in-block-email-and-in-soup-dont-live-update
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr's fixes live updating for emails in both the unified list and in email-block.
Two issues where causing this:
I'm not quite happy with the current invalidation pattern, as we continue to build out our own sync-engine we can establish some better patterns.
Ideally we define an interface that represents incoming invalidations, and we pass it to the query client provider. The query client provider mounts a single effects that handles
incoming invalidation messages and maps them to the correct resource and does some smarter reconciliation.