Conversation
gbirman
commented
Dec 9, 2025
| // }); | ||
| // } | ||
| // }) | ||
| // ); |
Contributor
Author
There was a problem hiding this comment.
im commenting this (user typing scroll to bottom) out cuz i think it's annoying, we can leave in though. but i would use the scroll bottom api with force bottom. lmk
sedson
approved these changes
Dec 10, 2025
gbirman
deleted the
gab/m-5359-channel-message-go-to-click-from-soup-not-working
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
there is some complicated interplay between the message list height and the virtualizer's own inner height estimations. my guess is the image preview suspense loading affects things, but even if you try to listen for size changes the virtualizer doesn't update its internals.
this fix uses
scrollIntoViewapi on the target element. i also ensure that the active target highlight starts after the element is scrolled into view so that it doesn't flash too quickly for an older message. also do a bunch of code cleanup.Screenshots, GIFs, and Videos
CleanShot.2025-12-09.at.17.56.56.mp4