fix: support message tag for empty message#535
Merged
Conversation
sedson
approved these changes
Dec 10, 2025
gbirman
commented
Dec 10, 2025
| !metadata.messageContent | ||
| ) | ||
| return ''; | ||
| if (!metadata || !('messageContent' in metadata)) return ''; |
Contributor
Author
There was a problem hiding this comment.
imo if message content is there it's still a message since you can send attachments with empty message
gbirman
deleted the
gab/fix/empty-message-should-still-show-message-tag
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
if the message content was "\n" it would be truthy but if it was "" it would be falsy. however both of these are still messages. @sedson will work on adding some sort of sent attachment text to make it clearer what's going on
Screenshots, GIFs, and Videos
in dev
