add preview project block from soup and project block#536
Conversation
|
@aquaductape taking a look now |
gbirman
left a comment
There was a problem hiding this comment.
issues:
- duplicate share buttons ( see below). this messed up tool bar exists for all previewed files/folders in project block because the share button will occupy full width but the filter/display buttons are only over the unified list view + we have two competing top bars. im not sure what ppl want from the ui exactly but can u sync with @synoet for what we should be doing because it's too jank atm
- can't click into project that's previewed. yes it's previewed but i may still want to open it completely. I guess this is general preview behavior so can be done in a follow up ticket: https://macro.com/app/channel/0195ceb6-ec2e-7023-80e4-6e084fa6cccd?message_id=019b0e36-c8e6-72cc-904f-16dbd09cabf2
- once preview project steals focus its very unintuitive/difficult to get the folders list back in focus so the j/k hotkeys work. like if i click back on the selected project it doesnt return focus
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Code reviewFound 1 issue: Conditional Hook Calls Violate Solid.js PatternsFile: Issue: Hooks are called inside a conditional block that depends on This means:
Lines 43-77 contain multiple hooks called inside
Suggested fix: Extract the project-specific logic into a separate component and use Reference: macro/js/app/packages/app/component/PreviewPanel.tsx Lines 42 to 78 in 9dcb3cd |
Uh oh!
There was an error while loading. Please reload this page.