add [properties-be] - pass in specific message id for threads#538
Merged
danielkweon merged 11 commits intomainfrom Dec 11, 2025
Merged
Conversation
Add optional specific_message_id field to EntityReference to support referencing specific messages within threads, channels, and chats. This allows properties to be associated with a specific message context when the entity type is THREAD, CHANNEL, or CHAT.
Refactor metadata property creation to use the cleaner EntityReference::new() constructor instead of struct literal syntax for owner and project references.
Refactor all entity property handlers to use the cleaner EntityReference::new() constructor for permission checks and entity reference creation.
…ructor Refactor all test code to use the cleaner EntityReference::new() constructor instead of struct literal syntax.
Expose api, config, and constants modules to allow external tooling and binaries to import properties_service modules. This enables OpenAPI schema generation without running the full service.
whutchinson98
requested changes
Dec 10, 2025
rust/cloud-storage/models_properties/src/shared/entity_reference.rs
Outdated
Show resolved
Hide resolved
whutchinson98
requested changes
Dec 10, 2025
| /// For CHANNEL, CHAT, THREAD entity types - optional specific message ID. | ||
| #[serde(skip_serializing_if = "Option::is_none")] | ||
| pub specific_message_id: Option<String>, | ||
| pub specific_message_id: Option<Uuid>, |
Member
There was a problem hiding this comment.
do we need this on system properties?
Contributor
Author
There was a problem hiding this comment.
yup - used for documents source property - specific message within the thread
whutchinson98
approved these changes
Dec 11, 2025
danielkweon
deleted the
daniel/m-5374--add-properties-be-pass-in-specific-message-id-for-threads
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add [properties-be] - pass in specific message id for threads