Skip to content

fix: scroll channel to bottom if notification has been deleted + notify user#550

Merged
gbirman merged 2 commits intomainfrom
gab/m-5383-scroll-channel-to-bottom-if-notification-has-been-deleted
Dec 11, 2025
Merged

fix: scroll channel to bottom if notification has been deleted + notify user#550
gbirman merged 2 commits intomainfrom
gab/m-5383-scroll-channel-to-bottom-if-notification-has-been-deleted

Conversation

@gbirman
Copy link
Copy Markdown
Contributor

@gbirman gbirman commented Dec 11, 2025

Summary

  • scrolls channel to bottom if target message not found (in this case notification message was deleted)
  • removes onlyBottom param and cleans up forceBottom
  • adds toast indicating message not found

Screenshots, GIFs, and Videos

CleanShot.2025-12-11.at.00.09.48.mp4

@gbirman gbirman requested a review from a team as a code owner December 11, 2025 05:14
@linear
Copy link
Copy Markdown

linear bot commented Dec 11, 2025

@gbirman gbirman force-pushed the gab/m-5383-scroll-channel-to-bottom-if-notification-has-been-deleted branch from befffaa to 61ba764 Compare December 11, 2025 05:14
@gbirman gbirman changed the base branch from gab/m-5385-channel-scroll-to-bottom-not-working-after-new-message-send to main December 11, 2025 05:15
@gbirman gbirman force-pushed the gab/m-5383-scroll-channel-to-bottom-if-notification-has-been-deleted branch from 61ba764 to 824c23c Compare December 11, 2025 05:17
@gbirman gbirman force-pushed the gab/m-5383-scroll-channel-to-bottom-if-notification-has-been-deleted branch from 824c23c to 16ae862 Compare December 11, 2025 05:18
@gbirman gbirman changed the title fix: scroll channel to bottom if notification has been deleted fix: scroll channel to bottom if notification has been deleted + notify user Dec 11, 2025
@gbirman gbirman merged commit 8113319 into main Dec 11, 2025
18 checks passed
@gbirman gbirman deleted the gab/m-5383-scroll-channel-to-bottom-if-notification-has-been-deleted branch December 11, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants