feat(search): return pretty sender email contact info from search backend#563
Merged
whutchinson98 merged 5 commits intomainfrom Dec 11, 2025
Conversation
seanaye
approved these changes
Dec 11, 2025
rust/cloud-storage/email_service_client/src/get_message_senders.rs
Outdated
Show resolved
Hide resolved
evanhutnik
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the email search metadata to include sender and pretty_sender regardless of whether it's a content or name match.
To do this, I exposed a new endpoint in email service
POST /messages/sendersto get the sender/pretty sender of the message ids.I also updated the
get_thread_historiesendpoint to contain the latest message in the thread's sender/pretty sender.I tested this locally and it populates the correct match for both name and content hits.
Screenshots, GIFs, and Videos