refactor(email-service): Separate email api and pubsub workers into separate services#594
Merged
evanhutnik merged 21 commits intomainfrom Jan 6, 2026
Merged
refactor(email-service): Separate email api and pubsub workers into separate services#594evanhutnik merged 21 commits intomainfrom
evanhutnik merged 21 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚨 🚨 🚨 🚨 🚨 Do Not Merge! Until Evan is back 🚨 🚨 🚨 🚨 🚨
Separate the email api and the email pubsub workers into separate bins/services.
The code still all lives in the
email-servicecrate, but the pubsub workers now have their own bin and fargate service.This required some refactoring of the pulumi code, namely moving the instantiation of a few things (IAM role, policies, s3 bucket) from
service.tsintoindex.ts.Both things still use the same
Configstruct (and env vars) for now.I had to move some code into modules under
lib.rsso it could be accessed by thepubsub_workersbin as well.Tested locally and in dev.
Screenshots, GIFs, and Videos