feat(search): add highlight support for owner fields#597
Merged
whutchinson98 merged 3 commits intomainfrom Dec 12, 2025
Merged
Conversation
gbirman
approved these changes
Dec 12, 2025
| // For content and name content search, we need to add in highlights for the owner | ||
| // fields | ||
| match args.search_on { | ||
| SearchOn::Content | SearchOn::NameContent => { |
Contributor
There was a problem hiding this comment.
i still feel like we should be building this in a composable way where we can distinguish between actual content and these more-so metadata fields. in the future i imagine we will have search for content:xxx from:yyy in:ddd and it'll be more difficult to disentangle if content encompasses all these things already. food for thought
Member
Author
There was a problem hiding this comment.
Yeah I agree, having a composable query language will definitely require changes to how we build the query. I think that is worth creating an RFD for and rebuilding as a separate project.
whutchinson98
force-pushed
the
hutch/bac-163-update-highlight-to-support-owner-fields
branch
from
02df19e to
9bba467
Compare
whutchinson98
deleted the
hutch/bac-163-update-highlight-to-support-owner-fields
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR add in highlight support for "owner" fields. It also adds in a boost on the owner queries so if you are searching an email it will prioritize matches that have a matching owner/participant over the raw content match itself.
Screenshots, GIFs, and Videos