fix[email]: sending emails with appended replies#601
Merged
peterchinman merged 5 commits intomainfrom Dec 15, 2025
Merged
Conversation
sedson
approved these changes
Dec 15, 2025
Contributor
sedson
left a comment
sedson
left a comment
There was a problem hiding this comment.
lgtm - lets merge if this fixes but could circle back cleanup/clarify whether this is embedding html strings or markdown
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the user appended thread replies in the email input, these appended replies would get included in
macro_body, and then would be preferentially displayed in the email message body. This is incorrect: we want appended replies to be hidden behind ellipsis button.To accomplish this I created a Lexical transformer for the
macro-quotenodes that we use for appended replies. This allows us to serialize themacro-quotenodes to markdown, allowing us to remove them frommacro-body.