fix(email-service): Notify for new messages after attachment upload#608
Merged
evanhutnik merged 2 commits intomainfrom Dec 12, 2025
Merged
fix(email-service): Notify for new messages after attachment upload#608evanhutnik merged 2 commits intomainfrom
evanhutnik merged 2 commits intomainfrom
Conversation
whutchinson98
approved these changes
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Don't notify users of new messages until after attachment upload. Prevents race condition where attachment hasn't been uploaded by the time the user gets the email notification.
this doesn't cover the edge case where the user is spam refreshing soup, in that case they could open the message before the attachments are uploaded, but peter and i agreed that's an edge case not worth worrying about right now. as long as the connection gateway refresh message and notification aren't sent until after upload it's good enough for now
Screenshots, GIFs, and Videos