feat(sps): use internal_date_ts for updated_at_seconds on email#622
Merged
whutchinson98 merged 1 commit intomainfrom Dec 15, 2025
Conversation
evanhutnik
approved these changes
Dec 15, 2025
seanaye
reviewed
Dec 15, 2025
Comment on lines
+28
to
+32
| let updated_at = message_info | ||
| .internal_date_ts | ||
| .map(|date| EpochSeconds::new(date.timestamp())) | ||
| .transpose()? | ||
| .unwrap_or(now); |
Contributor
There was a problem hiding this comment.
This code is repeated, could we dry it up? Also should we be erroring if the time doesn't exist? idk if it makes sense to insert now
Member
Author
There was a problem hiding this comment.
I think having it be now since it is optional and we still want to store the email is valid
whutchinson98
deleted the
hutch/bac-170-correctly-use-the-email-db-internal_date_ts-field-when
branch
aidanhb
pushed a commit
that referenced
this pull request
Dec 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Screenshots, GIFs, and Videos