fix(email-service): Attachment filetype guessing logic improvement#628
Merged
evanhutnik merged 3 commits intomainfrom Dec 15, 2025
Merged
fix(email-service): Attachment filetype guessing logic improvement#628evanhutnik merged 3 commits intomainfrom
evanhutnik merged 3 commits intomainfrom
Conversation
whutchinson98
approved these changes
Dec 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
If
mime_guesscan't determine the file type of the file, fallback to using everything after the last.in the filename.application/icsisn't supported bymime_guess, so calendar invites with that mime type were failing to download. fallback to using theicsininvite.ics.Also sometimes images have a .heic filename but a heif mime_type. heic is a subset of heif. In these cases, force the file type to be heic, so we don't upload the user's heic as an heif by guessing file type based on the mime_type.
Also store filename extensions as lowercase in the database. Will update existing ones later.
Screenshots, GIFs, and Videos