add [properties-fe] - filter and sort to unified list filter

[danielkweon]

add [properties-fe] - filter and sort to unified list filter

[linear]

M-4977 - add [properties-frontend] - filter and sort to unified list

[github-actions]

Preview: https://daniel-m-4977-add-properties-f-wpr2in.preview.macro.com/app (00ac1de)

[sedson]

Changes talked about in MacroChat:

• fix menus closing on select for operators
• cleanup multiple files of incorrect click outside pattern
• remove all cursor-pointer classes

[sedson]

no cursor-pointer

[claude]

Code Review

I've reviewed this PR and found 4 CLAUDE.md violations that need to be addressed:

1. Direct service client calls (3 instances)

The following files make direct calls to service clients outside the queries package, violating CLAUDE.md line 27-28:

"Going forward, all network calls to serice clients should be done through Tanstack query in the queries package. DO NOT introduce code that calls any client from service-clients outside of the queries package."

a) FilterValueSelect.tsx (lines 36-38) - Direct call to propertiesServiceClient.getPropertyOptions()

b) FilterValueSelectMulti.tsx (lines 39-41) - Direct call to propertiesServiceClient.getPropertyOptions()

c) typeGuards.ts (lines 120-123) - Direct call to propertiesServiceClient.listProperties()

Fix: Create query hooks in the queries/properties package and use those instead of direct service client calls.

---

2. Use of any type (7 instances)

FilterPropertyPill.tsx uses 'as any' type assertions in 7 places (lines 352, 360, 367, 375, 382, 391, 398), violating CLAUDE.md line 13:

"Type-driven design - Let types guide function composition. DO NOT USE any"

Fix: Properly type the filterAction parameter for each data type case to eliminate the need for 'as any' casts.

---

Summary: Please refactor to use the queries package for all network calls and fix the type safety issues before merging.

[claude]

Code Review

I've reviewed this PR for bugs and CLAUDE.md compliance. Found the following issues:

Issue 1: Use of any type assertions in FilterPropertyPill.tsx

Lines: 352, 360, 367, 375, 382, 391, 398, 405

The code uses as any type assertions which violates the CLAUDE.md rule:

"Type-driven design - Let types guide function composition. DO NOT USE any"

Reference: CLAUDE.md L13

The buildPartialFilter function contains multiple action: filterAction as any statements that bypass TypeScript's type checking. The proper solution would be to use type guards or type narrowing to ensure the action type matches the data type being filtered.

Location: FilterPropertyPill.tsx#L350-L407

---

Issue 2: Direct service client call in FilterValueSelect.tsx

Line: 36

The code directly calls propertiesServiceClient.getPropertyOptions() outside the queries package, violating:

"Going forward, all network calls to serice clients should be done through Tanstack query in the queries package. DO NOT introduce code that calls any client from service-clients outside of the queries package."

Reference: CLAUDE.md L27

This network call should be wrapped in a Tanstack query hook and placed in the queries package, then imported and used in the component.

Location: FilterValueSelect.tsx#L34-L38

---

Issue 3: Direct service client call in FilterValueSelectMulti.tsx

Line: 39

Same issue as above - direct call to propertiesServiceClient.getPropertyOptions() outside the queries package.

Reference: CLAUDE.md L27

Location: FilterValueSelectMulti.tsx#L37-L41

---

Issue 4: Direct service client call in typeGuards.ts

Line: 120

The new listPropertiesFlat() function directly calls propertiesServiceClient.listProperties() outside the queries package.

Reference: CLAUDE.md L27

Network calls to service clients should be done through the queries package following the pattern in packages/queries/properties/.

Location: typeGuards.ts#L118-L122