Skip to content

add [tasks] - quick create task endpoint#675

Merged
danielkweon merged 5 commits intomainfrom
daniel/m-5426--add-tasks-quick-create-menu
Dec 31, 2025
Merged

add [tasks] - quick create task endpoint#675
danielkweon merged 5 commits intomainfrom
daniel/m-5426--add-tasks-quick-create-menu

Conversation

@danielkweon
Copy link
Copy Markdown
Contributor

@danielkweon danielkweon commented Dec 16, 2025

add [tasks] - quick create endpoint

  • Adds POST /documents/create_task endpoint for creating tasks with properties in one call
  • Refactors search notification into create_document_v2 to reduce code duplication
  • Task content initialization deferred to client via sync service (Loro/Lexical limitation)
  • Includes swagger docs and generated TypeScript client schemas

depends on #752

@danielkweon danielkweon self-assigned this Dec 16, 2025
@danielkweon danielkweon requested a review from a team as a code owner December 16, 2025 20:34
@linear
Copy link
Copy Markdown

linear bot commented Dec 16, 2025

@danielkweon danielkweon changed the title add [tasks] - quick create menu add [tasks] - quick create endpoint Dec 16, 2025
@danielkweon danielkweon requested a review from a team as a code owner December 16, 2025 21:08
@github-actions github-actions bot added the infra label Dec 16, 2025
@danielkweon danielkweon requested a review from a team as a code owner December 16, 2025 22:11
@danielkweon danielkweon force-pushed the daniel/m-5426--add-tasks-quick-create-menu branch 2 times, most recently from 0692f59 to f09c81e Compare December 17, 2025 00:03
@danielkweon danielkweon marked this pull request as draft December 17, 2025 16:10
Comment on lines +75 to +91
.route(
"/quick_create_task",
post(quick_create_task::quick_create_task_handler).layer(
ServiceBuilder::new()
.layer(axum::middleware::from_fn(
macro_middleware::auth::ensure_user_exists::handler,
))
.layer(axum::middleware::from_fn_with_state(
state.clone(),
macro_middleware::user_permissions::attach_user_permissions::handler,
))
.layer(axum::middleware::from_fn_with_state(
state.clone(),
macro_middleware::user_permissions::validate_user_quota::document_handler,
)),
),
)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can already create tasks through the POST /documents endpoint why are we making a custom 1-off way to create tasks in DSS?

Copy link
Copy Markdown
Contributor Author

@danielkweon danielkweon Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick_create_task provides:

  • Single call to create task + set properties
  • Simplified API for quick task creation UX

@danielkweon danielkweon force-pushed the daniel/m-5426--add-tasks-quick-create-menu branch from f9ecfac to f8b0d84 Compare December 23, 2025 19:52
@danielkweon danielkweon changed the title add [tasks] - quick create endpoint add [tasks] - quick create task endpoint Dec 23, 2025
@danielkweon danielkweon marked this pull request as ready for review December 23, 2025 19:53
@danielkweon danielkweon changed the base branch from main to daniel/m-5426--add-tasks-quick-create-menu-hexagon-migration December 23, 2025 19:53
@danielkweon danielkweon force-pushed the daniel/m-5426--add-tasks-quick-create-menu branch from f8b0d84 to 79dfa77 Compare December 23, 2025 20:57
@danielkweon danielkweon force-pushed the daniel/m-5426--add-tasks-quick-create-menu-hexagon-migration branch from bd1c015 to 5881479 Compare December 23, 2025 20:58
@danielkweon danielkweon force-pushed the daniel/m-5426--add-tasks-quick-create-menu branch from 79dfa77 to 39b8a96 Compare December 23, 2025 20:59
@danielkweon danielkweon force-pushed the daniel/m-5426--add-tasks-quick-create-menu branch from 39b8a96 to a58e565 Compare December 23, 2025 21:49
@danielkweon danielkweon force-pushed the daniel/m-5426--add-tasks-quick-create-menu-hexagon-migration branch from 0528aa8 to 9a8b677 Compare December 23, 2025 22:26
@danielkweon danielkweon force-pushed the daniel/m-5426--add-tasks-quick-create-menu branch from a58e565 to 72c5539 Compare December 23, 2025 22:30
Copy link
Copy Markdown
Contributor

@synoet synoet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly fine. Please address some of the nits.

Does this pr include permission updating if it has assignees ?

@danielkweon danielkweon force-pushed the daniel/m-5426--add-tasks-quick-create-menu-hexagon-migration branch from e02b159 to 6d5b963 Compare December 28, 2025 23:01
Base automatically changed from daniel/m-5426--add-tasks-quick-create-menu-hexagon-migration to main December 28, 2025 23:14
@danielkweon danielkweon force-pushed the daniel/m-5426--add-tasks-quick-create-menu branch from 72c5539 to 11d87cf Compare December 30, 2025 22:07
@danielkweon danielkweon force-pushed the daniel/m-5426--add-tasks-quick-create-menu branch 2 times, most recently from 1cfe406 to 919a24a Compare December 31, 2025 04:22
@danielkweon danielkweon force-pushed the daniel/m-5426--add-tasks-quick-create-menu branch from 919a24a to 65cda09 Compare December 31, 2025 04:25
@danielkweon danielkweon dismissed whutchinson98’s stale review December 31, 2025 19:27

comments have been addressed

@danielkweon danielkweon merged commit 2feb051 into main Dec 31, 2025
37 checks passed
@danielkweon danielkweon deleted the daniel/m-5426--add-tasks-quick-create-menu branch December 31, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants