add [tasks] - quick create task endpoint#675
Merged
danielkweon merged 5 commits intomainfrom Dec 31, 2025
Merged
Conversation
0692f59 to
f09c81e
Compare
whutchinson98
previously requested changes
Dec 17, 2025
Comment on lines
+75
to
+91
| .route( | ||
| "/quick_create_task", | ||
| post(quick_create_task::quick_create_task_handler).layer( | ||
| ServiceBuilder::new() | ||
| .layer(axum::middleware::from_fn( | ||
| macro_middleware::auth::ensure_user_exists::handler, | ||
| )) | ||
| .layer(axum::middleware::from_fn_with_state( | ||
| state.clone(), | ||
| macro_middleware::user_permissions::attach_user_permissions::handler, | ||
| )) | ||
| .layer(axum::middleware::from_fn_with_state( | ||
| state.clone(), | ||
| macro_middleware::user_permissions::validate_user_quota::document_handler, | ||
| )), | ||
| ), | ||
| ) |
Member
There was a problem hiding this comment.
We can already create tasks through the POST /documents endpoint why are we making a custom 1-off way to create tasks in DSS?
Contributor
Author
There was a problem hiding this comment.
quick_create_task provides:
- Single call to create task + set properties
- Simplified API for quick task creation UX
...ge/document_storage_service/src/api/documents/quick_create_task/quick_create_task_handler.rs
Outdated
Show resolved
Hide resolved
...ge/document_storage_service/src/api/documents/quick_create_task/quick_create_task_handler.rs
Outdated
Show resolved
Hide resolved
rust/cloud-storage/properties_service_client/src/set_entity_property.rs
Outdated
Show resolved
Hide resolved
...ge/document_storage_service/src/api/documents/quick_create_task/quick_create_task_handler.rs
Outdated
Show resolved
Hide resolved
f9ecfac to
f8b0d84
Compare
f8b0d84 to
79dfa77
Compare
bd1c015 to
5881479
Compare
79dfa77 to
39b8a96
Compare
39b8a96 to
a58e565
Compare
0528aa8 to
9a8b677
Compare
a58e565 to
72c5539
Compare
synoet
approved these changes
Dec 27, 2025
Contributor
synoet
left a comment
There was a problem hiding this comment.
Mostly fine. Please address some of the nits.
Does this pr include permission updating if it has assignees ?
...oud-storage/document_storage_service/src/api/documents/create_document/create_document_v2.rs
Outdated
Show resolved
Hide resolved
rust/cloud-storage/document_storage_service/src/api/documents/create_task.rs
Outdated
Show resolved
Hide resolved
rust/cloud-storage/document_storage_service/src/api/documents/create_task.rs
Outdated
Show resolved
Hide resolved
rust/cloud-storage/document_storage_service/src/api/documents/create_task.rs
Outdated
Show resolved
Hide resolved
rust/cloud-storage/document_storage_service/src/api/documents/create_task.rs
Outdated
Show resolved
Hide resolved
e02b159 to
6d5b963
Compare
Base automatically changed from
daniel/m-5426--add-tasks-quick-create-menu-hexagon-migration
to
main
December 28, 2025 23:14
72c5539 to
11d87cf
Compare
1cfe406 to
919a24a
Compare
919a24a to
65cda09
Compare
comments have been addressed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add [tasks] - quick create endpoint
depends on #752