Skip to content

chore(ui): drastically simplify button components#733

Merged
nickisnoble merged 34 commits intomainfrom
nick/there-can-only-be-one-button
Jan 5, 2026
Merged

chore(ui): drastically simplify button components#733
nickisnoble merged 34 commits intomainfrom
nick/there-can-only-be-one-button

Conversation

@nickisnoble
Copy link
Copy Markdown
Contributor

@nickisnoble nickisnoble commented Dec 19, 2025

  • Collapses our six different button primitives into one Button.tsx
  • Drastically simplifies the API, relying on composition instead of injection to work with other components (like icons or hotkey hints)

@nickisnoble
Copy link
Copy Markdown
Contributor Author

nickisnoble commented Dec 19, 2025

@sedson

Which do we like better for variants:

  • 🅰️ Inline boolean <Button primary />
  • 🅱️ Explicit prop <Button variant="primary" />

EDIT: Chose 🅱️. Less clever under the hood, more clear about what it is / does, intellisense, etc.

@nickisnoble nickisnoble marked this pull request as ready for review December 22, 2025 21:34
@nickisnoble nickisnoble requested a review from a team as a code owner December 22, 2025 21:34
@nickisnoble nickisnoble changed the title THERE CAN BE ONLY ONE (button component) chore(ui) - drastically simplify button components Dec 23, 2025
@nickisnoble nickisnoble changed the title chore(ui) - drastically simplify button components chore(ui): drastically simplify button components Dec 23, 2025
@nickisnoble
Copy link
Copy Markdown
Contributor Author

nickisnoble commented Dec 23, 2025

Looks like there's a segfault during build?! cc @synoet

Could not recreate locally.

@synoet
Copy link
Copy Markdown
Contributor

synoet commented Dec 23, 2025

Re run the actions manually

@nickisnoble
Copy link
Copy Markdown
Contributor Author

This is 80% renamings, but I did apply the new buttons to a few major surfaces:

  • email/BaseInput
  • SplitHeader
  • Dock

@nickisnoble nickisnoble merged commit f7e6f5f into main Jan 5, 2026
19 checks passed
@nickisnoble nickisnoble deleted the nick/there-can-only-be-one-button branch January 5, 2026 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants