add [tasks] - grant permissions to task assignee#760
Merged
danielkweon merged 1 commit intomainfrom Dec 30, 2025
Conversation
danielkweon
force-pushed
the
daniel/m-5426--add-tasks-quick-create-menu-hexagon-migration
branch
2 times, most recently
from
0528aa8 to
9a8b677
Compare
danielkweon
force-pushed
the
daniel/m-5426--add-tasks-quick-create-menu-hexagon-migration-notification-permissions
branch
from
2cb1284 to
d188776
Compare
cowlicks
approved these changes
Dec 23, 2025
Contributor
cowlicks
left a comment
cowlicks
left a comment
There was a problem hiding this comment.
Looks great, thank you.
synoet
approved these changes
Dec 27, 2025
Contributor
synoet
left a comment
synoet
left a comment
There was a problem hiding this comment.
Overall fine. But please address my comments before merging.
Comment on lines
+89
to
+96
| &self, | ||
| user_ids: &[String], | ||
| entity_id: &str, | ||
| entity_type: EntityType, | ||
| ) -> Result<(), Self::Err> { | ||
| if user_ids.is_empty() { | ||
| return Ok(()); | ||
| } |
Contributor
There was a problem hiding this comment.
nit: @whutchinson98 had a utility somewhere for taking a Vec/Slice of non-zero length maybe use that ?
Contributor
Author
There was a problem hiding this comment.
hutch - can you point me to the util?
rust/cloud-storage/properties/src/outbound/permission_service.rs
Outdated
Show resolved
Hide resolved
danielkweon
force-pushed
the
daniel/m-5426--add-tasks-quick-create-menu-hexagon-migration
branch
from
e02b159 to
6d5b963
Compare
Base automatically changed from
daniel/m-5426--add-tasks-quick-create-menu-hexagon-migration
to
main
December 28, 2025 23:14
danielkweon
force-pushed
the
daniel/m-5426--add-tasks-quick-create-menu-hexagon-migration-notification-permissions
branch
3 times, most recently
from
e328dc6 to
1843f03
Compare
danielkweon
force-pushed
the
daniel/m-5426--add-tasks-quick-create-menu-hexagon-migration-notification-permissions
branch
2 times, most recently
from
29e6dc5 to
25dddd3
Compare
- Add grant_permissions_to_task method to PermissionService trait - Implement permission granting in PermissionServiceImpl using upsert_user_item_access_bulk - Grant edit permissions to all assignees when task assignees are updated - Add tests for permission granting functionality
danielkweon
force-pushed
the
daniel/m-5426--add-tasks-quick-create-menu-hexagon-migration-notification-permissions
branch
from
25dddd3 to
7e9dc31
Compare
danielkweon
changed the title
danielkweon
deleted the
daniel/m-5426--add-tasks-quick-create-menu-hexagon-migration-notification-permissions
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add [tasks] - add notifications and permissions when assigning a task