Merged
Conversation
synoet
approved these changes
Dec 27, 2025
Contributor
synoet
left a comment
synoet
left a comment
There was a problem hiding this comment.
Code looks good.
Is it not going to be strange to have duplication in both the bottom dock and in the tabs ?
Comment on lines
+138
to
+148
| const activeSplit = createMemo(() => { | ||
| const manager = globalSplitManager(); | ||
| if (!manager) return; | ||
| const activeSplitId = manager.activeSplitId(); | ||
| return activeSplitId ? manager.getSplit(activeSplitId) : undefined; | ||
| }); | ||
|
|
||
| const isSettingsSplitOpen = createMemo(() => { | ||
| const content = activeSplit()?.content(); | ||
| return content?.type === 'component' && content.id === 'settings'; | ||
| }); |
Contributor
There was a problem hiding this comment.
pull these both out, might be helpful elsewhere.
Contributor
Author
@synoet Most recent talk with Jacob, it seems like Tabs might die, in favor of Filter-First Vision. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements a mobile dock, for ease of navigation on mobile.
Makes the settings panel accessible on mobile.
Implements various small UI fixes for mobile.
Changes
isTouchDeviceimplementation to match other utilities.