fix: add unauthed retry to legacy api rpc client #777
Merged
Conversation
seanaye
reviewed
Jan 5, 2026
| throw error; | ||
| } | ||
|
|
||
| rpcClientInstance = null; |
Contributor
There was a problem hiding this comment.
instead of nullifying the client, can we just reload the headers, the client always call the function to get the recent headers. Allocating a new client each time seems very heavy. Otherwise looks good
Contributor
Author
There was a problem hiding this comment.
updated, ENABLE_BEARER_TOKEN_AUTH is false atm so the new code path isn't actually used but if we flag it on it'll update the headers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@seanaye feel free to add middleware to the client gen code if you want as a follow up
Screenshots, GIFs, and Videos