Skip to content

fix(soup): file assoc cursor#780

Merged
seanaye merged 2 commits intomainfrom
seanaye/fix/assoc-cursor
Jan 5, 2026
Merged

fix(soup): file assoc cursor#780
seanaye merged 2 commits intomainfrom
seanaye/fix/assoc-cursor

Conversation

@seanaye
Copy link
Copy Markdown
Contributor

@seanaye seanaye commented Jan 5, 2026

Summary

This PR fixes a recursion depth limit when deserializing large cursor values.

To prevent DOS attacks we set an upper size limit of 16kb for deserializing cursors with an unbounded recursion depth.

We also greatly reduce the json key sizes for cursors which is a non-breaking change because they are opaque to the client.

There are new errors to tell the client if the cursor is too big, and there is a unit test to assert the assoc:other filter cursor deserializes

  • fix filter deserialize with large values
  • update tests

Screenshots, GIFs, and Videos

@seanaye seanaye requested a review from a team as a code owner January 5, 2026 19:35
@seanaye seanaye requested a review from gbirman January 5, 2026 19:35
@seanaye seanaye force-pushed the seanaye/fix/assoc-cursor branch from bdff369 to db4f652 Compare January 5, 2026 19:49
@seanaye seanaye force-pushed the seanaye/fix/assoc-cursor branch from db4f652 to 7f4035b Compare January 5, 2026 20:05
@seanaye seanaye merged commit 562aa9e into main Jan 5, 2026
37 checks passed
@seanaye seanaye deleted the seanaye/fix/assoc-cursor branch January 5, 2026 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants