Merged
Conversation
seanaye
reviewed
Jan 5, 2026
| request: MarkdownRewrite, | ||
| scribe: &ToolScribe, | ||
| _user_id: &str, | ||
| jwt: &str, |
Contributor
There was a problem hiding this comment.
nit: ask for what you need, we need an owned String so this should take a String
whutchinson98
approved these changes
Jan 5, 2026
seanaye
reviewed
Jan 5, 2026
| let user_id = user_context.user_id.clone(); | ||
|
|
||
| if matches!(user_id.as_str(), "" | "INTERNAL") { | ||
| if matches!(user_id.as_str(), "" | MACRO_INTERNAL_USER_ID) { |
Contributor
There was a problem hiding this comment.
I'm curious whats going on here? What is the motivation for this change? This suggests that something was being allowed in that shouldn't have access
Contributor
Author
There was a problem hiding this comment.
Yea you've pretty much got it. The internal access endpoints use a custom user id and grant owner permissions to stuff. Its aids. It's an old system that should be replaced by sending a jwt (which is why I changed endpoints where it was easy).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal access was broken with
e2b8be8which updated user id parsing. Thisupdates the internal user id to be compatible with new parsing.
Internal access is a blight on the codebase, but is still a dependency of DCS.