Merged
Conversation
…ol-to-mark-soup-items-as-done
… components. Added touch modality detection and adjusted event listeners for keyboard and mouse interactions. Refactored swipe handling to unify left and right swipe logic.
…control-to-mark-soup-items-as-done
jbecke
approved these changes
Jan 6, 2026
peterchinman
commented
Jan 6, 2026
| unifiedListContext.collapseEntity!(entity.id) | ||
| ) | ||
| ); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This could be done more robustly by generically animating Entity's removal from the DOM. Worth doing?
Contributor
Author
There was a problem hiding this comment.
This is complicated because we are using virtualized lists. I have an idea for this that I will try out in another PR. For now, this works.
peterchinman
commented
Jan 6, 2026
synoet
reviewed
Jan 6, 2026
peterchinman
deleted the
peter/mob-26-gesture-control-to-mark-soup-items-as-done
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements swipe gestures to mark as done for Soup entities.
Marking as Done now also collapses the Entity Row on Desktop.
Introduces new tailwind selectors
touch:andmobile-width:Introduces new utilities for checking which input modality is currently being used.
Starts to correctly differentiate between cases where we want to gate based on:
is native mobile appvsis primarily touch devicevsis mobile widthSimulator.Screen.Recording.-.iPhone.16.Pro.-.2026-01-05.at.17.12.44.mov