move from names index to querying macrodb directly#793
Merged
whutchinson98 merged 19 commits intomainfrom Jan 6, 2026
Merged
Conversation
seanaye
approved these changes
Jan 6, 2026
Contributor
seanaye
left a comment
seanaye
left a comment
There was a problem hiding this comment.
This seems good to me although I don't have the most search context
rust/cloud-storage/search_service/src/api/search/simple/simple_document.rs
Outdated
Show resolved
Hide resolved
rust/cloud-storage/search_service/src/api/search/simple/filter.rs
Outdated
Show resolved
Hide resolved
rust/cloud-storage/search_service/src/api/search/simple/simple_unified.rs
Show resolved
Hide resolved
rust/cloud-storage/search_service/src/api/search/simple/simple_channel.rs
Outdated
Show resolved
Hide resolved
whutchinson98
deleted the
hutch/bac-181-move-from-names-index-to-querying-macrodb-directly
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR moves us from searching over the
namesindex in opensearch to searching over macrodb directly. This is needed to simplify handling data-sync across multiple dbs as we no longer need to update both macrodb and opensearch when an item's name is changed.This PR is best if reviewed per-commit as it's quite a big one.
Note: this does break pagination since we no longer search across all indices at once for unified search. That is a separate issue that we will have to address later
Screenshots, GIFs, and Videos