Skip to content

chg/fix(notifications): use tanstack as source of truth for optimistic updating, simplifies source#815

Merged
synoet merged 1 commit intomainfrom
synoet/optimistic-notification-update
Jan 7, 2026
Merged

chg/fix(notifications): use tanstack as source of truth for optimistic updating, simplifies source#815
synoet merged 1 commit intomainfrom
synoet/optimistic-notification-update

Conversation

@synoet
Copy link
Copy Markdown
Contributor

@synoet synoet commented Jan 7, 2026

  • Uses tanstack data as the source of truth for optimistic inserts and removes with the ws
  • notification-source becomes alot simpler. just derive data from the query data and group it by composite key.
  • updates helpers

This fixes some issues I was seeing in dev where notification reconciling was incorrect due to how we handle optimistic remove on tanstack.
This is a move in the right direction anyway.

Next Steps:

  • Websocket invalidation / optimistic updating of notifications should happen in the query package.
  • Once this happens notification-source can be drastically simplified and maybe even removed.

@synoet synoet requested a review from a team as a code owner January 7, 2026 00:32
@synoet synoet requested a review from dev-rb January 7, 2026 00:33
@synoet synoet merged commit 7275d8a into main Jan 7, 2026
20 checks passed
@synoet synoet deleted the synoet/optimistic-notification-update branch January 7, 2026 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants