Merged
Conversation
danielkweon
reviewed
Jan 8, 2026
| if refs.is_empty() { | ||
| None | ||
| } else { | ||
| let ids: Vec<String> = refs.iter().map(|r| r.entity_id.clone()).collect(); |
Contributor
There was a problem hiding this comment.
do you want to resolve entity_type + entity_id to an actual name?
in properties context entity_type = task -> document + subtype task. so if AI makes more tool calls i can see it making a mistake here.
Contributor
Author
There was a problem hiding this comment.
Good catch. Will revisit
danielkweon
reviewed
Jan 8, 2026
| .content | ||
| .properties | ||
| .clone() | ||
| .map(|p| Properties::from_properties(EntityType::Task, p)); |
Contributor
There was a problem hiding this comment.
is this hardcoding intentional?
Contributor
Author
There was a problem hiding this comment.
The endpoint returns nothing if it's not a task which formats correctly. We only care about properties for tasks for now.
danielkweon
reviewed
Jan 8, 2026
| properties_db_client::entity_properties::get::get_entity_properties_values( | ||
| &self.macro_db, | ||
| &self.document_id, | ||
| models_properties::EntityType::Task, |
ehayes2000
force-pushed
the
integrate-properties
branch
2 times, most recently
from
b23522f to
8aea631
Compare
ehayes2000
force-pushed
the
integrate-properties
branch
from
8aea631 to
b1a4f5f
Compare
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
danielkweon
approved these changes
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add property fetching with documents