fix(notifications): use correct name for dm name#875
Merged
Conversation
synoet
force-pushed
the
synoet/notification-dms
branch
from
6a264cf to
c5ee78e
Compare
whutchinson98
approved these changes
Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve_channel_namereturns a dynamic channel name for the SENDER not the RECIPIENT of the notification.Because of this Direct Message notifications show up as from the person who receives it not he who sent it.
The name of my DM with Hutch for hutch is Teo. Because for him he is chatting with me. So it sends
channel_nameTeo.Technically this is also broken for private channels without names (dyanmic name from participants). And is filtering out the name of the
senderbut we can clean that one up later.