feat(search) support cursor for unified search#892
Merged
whutchinson98 merged 28 commits intomainfrom Jan 13, 2026
Merged
Conversation
whutchinson98
force-pushed
the
hutch/bac-192-support-cursor-for-unified-search
branch
from
f64440e to
59c6bae
Compare
Contributor
|
nice, lemme stack FE pr on this and see if it works. we can merge together |
seanaye
reviewed
Jan 9, 2026
rust/cloud-storage/search_service/src/api/search/simple/simple_unified.rs
Show resolved
Hide resolved
rust/cloud-storage/search_service/src/api/search/simple/simple_unified.rs
Show resolved
Hide resolved
rust/cloud-storage/search_service/src/api/search/simple/simple_unified.rs
Show resolved
Hide resolved
rust/cloud-storage/search_service/src/api/search/simple/simple_unified.rs
Show resolved
Hide resolved
rust/cloud-storage/search_service/src/api/search/simple/simple_unified.rs
Show resolved
Hide resolved
rust/cloud-storage/search_service/src/api/search/simple/simple_unified.rs
Outdated
Show resolved
Hide resolved
rust/cloud-storage/search_service/src/api/search/simple/simple_unified.rs
Outdated
Show resolved
Hide resolved
whutchinson98
force-pushed
the
hutch/bac-192-support-cursor-for-unified-search
branch
2 times, most recently
from
9c8fe47 to
b237c44
Compare
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
whutchinson98
force-pushed
the
hutch/bac-192-support-cursor-for-unified-search
branch
from
ee34869 to
0727437
Compare
|
🔥 |
whutchinson98
deleted the
hutch/bac-192-support-cursor-for-unified-search
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR overhauls our current search approach to move to a complex cursor based search.
We now create a cursor for each search method (document name, email subject, content etc) and pack our result with all of these items sorted by updated at. We then generate a new combined cursor for each of these methods to be used to get the next page of information.
This PR also removes all of the unused search endpoints since supporting them has become cumbersome with the cursor changes.
Screenshots, GIFs, and Videos