Skip to content

chore: remove insight service#897

Merged
ehayes2000 merged 3 commits intomainfrom
sunset-insight-service
Jan 9, 2026
Merged

chore: remove insight service#897
ehayes2000 merged 3 commits intomainfrom
sunset-insight-service

Conversation

@ehayes2000
Copy link
Copy Markdown
Contributor

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 9, 2026

@ehayes2000 ehayes2000 force-pushed the sunset-insight-service branch from f2f1cef to d47cdc0 Compare January 9, 2026 20:57
@ehayes2000 ehayes2000 force-pushed the sunset-insight-service branch from d47cdc0 to 1713b99 Compare January 9, 2026 20:58
@ehayes2000 ehayes2000 marked this pull request as ready for review January 9, 2026 21:38
@ehayes2000 ehayes2000 requested review from a team as code owners January 9, 2026 21:38
Copy link
Copy Markdown
Member

@whutchinson98 whutchinson98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving assuming CI passes

@ehayes2000 ehayes2000 merged commit 28743fd into main Jan 9, 2026
40 checks passed
@ehayes2000 ehayes2000 deleted the sunset-insight-service branch January 9, 2026 22:01
@claude
Copy link
Copy Markdown
Contributor

claude bot commented Jan 9, 2026

Code Review

Found 1 issue that needs attention:

Missing .sqlx Cache Files

File: rust/cloud-storage/macro_db_client/src/chat_history/mod.rs (lines 21 and 50)

This new file introduces SQL queries using sqlx::query_as! macros in two functions:

  • get_chat_history()
  • get_chat_history_for_messages()

However, no corresponding .sqlx cache files were added to the PR.

According to rust/cloud-storage/CLAUDE.md:

Any time you make changes to the SQL code in rust, you need to run just prepare_db in macro-api/cloud-storage/macro_db_client to update the .sqlx.

Why this matters: SQLx uses offline mode (SQLX_OFFLINE=true) for compilation without database connections. When new SQL queries are added, running just prepare_db generates cached query metadata in the .sqlx/ directory that allows the code to compile and validates query correctness at build time. Without these cache files, the build may fail in CI/CD environments.

Suggested fix:

cd rust/cloud-storage/macro_db_client
just prepare_db

Then commit the generated .sqlx/*.json files.


Summary: Checked for bugs and CLAUDE.md compliance. Found 1 CLAUDE.md adherence issue that needs to be addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants