Conversation
synoet
commented
Jan 9, 2026
Extract isMessageFromCurrentUser, getSenderDisplayName, and getRecipientDisplayName into a shared util file to eliminate code duplication across CollapsedMessage, MessageContainer, and EmailMessageTopBar components. Co-authored-by: teo <synoet@users.noreply.github.com>
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
dev-rb
approved these changes
Jan 9, 2026
Contributor
dev-rb
left a comment
dev-rb
left a comment
There was a problem hiding this comment.
Looks good to me, may need Peter's thoughts on the UI
Contributor
|
Actually, we might want to add the scroll logic I added in #798 so that when you expand a message you're seeing it from the start instead of it opening out of view because of the flex reverse logic |
synoet
commented
Jan 9, 2026
synoet
commented
Jan 9, 2026
Co-authored-by: teo <synoet@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CleanShot.2026-01-09.at.16.21.41.mp4